feat(micropub): add proposed contacts extension - #368

Automated code review.

CONTRIBUTING.md conformance: PASS. Title/scope, PR template headings, changeset (.changeset/micropub-contacts.md), and spec update are all in order. The unticked "full CI gate" and "catalog.json" boxes carry one-line reasons, which matches the "leave unchecked with a reason" rule — not a violation, but please run the full pnpm lint && pnpm format:check && pnpm typecheck && pnpm build && pnpm test before taking this out of draft.

Code issues found:

1. Should-fix — silent data loss on multipart contact create. In handleAction() (packages/micropub/src/handler.ts), the isContactRequest branch returns before the foldUploadedMedia/pendingFiles block runs. A ?q=contact create sent as multipart/form-data with a photo file returns 201 but the file is never uploaded to R2 or folded into properties — silently dropped. Given this repo's "fail loudly, no silent degradation" convention, please either fold uploads for contacts too or explicitly reject multipart contact requests.

2. Should-fix — missing scope-enforcement test. The new describe("@dwk/micropub proposed contacts") tests never check that a token without the right scope (e.g. create-only attempting action=delete) gets insufficient_scope/403. scopesForAction is reused unmodified from the post path so it's likely correct, but the spec explicitly calls out per-action scoping for contacts and it's currently unverified by any test.

3. Worth confirming — contacts readable by any authenticated token. handleQuery() calls authorize(..., [], ...), so any valid token (even media-scoped) can read the address book. This mirrors existing q=source behavior, but since the new spec text calls contacts "private owner data," please confirm that's intentional rather than inherited by accident.

4. Nit — contactView() collapses single-value properties to a bare scalar, diverging from the array-always shape sourceView() and the rest of the mf2 JSON surface use. Called out in the added spec text, but flagging since it could surprise clients sharing mf2-parsing code across q=source/q=contact.

5. Nit — the "URL already in use" conflict message is identical for a genuine URL-identity conflict and a (practically impossible) UUID PK collision; harmless but slightly misleading.

No injection/auth-bypass issues found — parameterized D1 queries throughout, DPoP/scope gating structurally correct, no KV usage.

Generated by Claude Code